Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial skeleton #1

Merged
merged 8 commits into from
Mar 6, 2023
Merged

Initial skeleton #1

merged 8 commits into from
Mar 6, 2023

Conversation

S-Dafarra
Copy link
Member

No description provided.

@S-Dafarra
Copy link
Member Author

Thanks @traversaro. Waiting also for @diegoferigo approval since I inherited the structure from https://github.com/ami-iit/rod

@traversaro
Copy link
Contributor

Just a small comment: if you want to take blf as a dependency, you may want to drop the part of CI related to PyPI packaging, as blf is not available on PyPI.

@S-Dafarra
Copy link
Member Author

Just a small comment: if you want to take blf as a dependency, you may want to drop the part of CI related to PyPI packaging, as blf is not available on PyPI.

Ah, you mean this part https://github.com/ami-iit/stepwise/blob/fab37f0aef4d67002258633eea2ddfde8027d962/.github/workflows/ci_cd.yml#L12-L46 ?

@traversaro
Copy link
Contributor

Yes.

Copy link
Member

@diegoferigo diegoferigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few comments here and there, approving in any case.

setup.cfg Outdated Show resolved Hide resolved
setup.cfg Outdated Show resolved Hide resolved
setup.cfg Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
.github/workflows/ci_cd.yml Outdated Show resolved Hide resolved
@diegoferigo
Copy link
Member

Just a small comment: if you want to take blf as a dependency, you may want to drop the part of CI related to PyPI packaging, as blf is not available on PyPI.

Related to the very old activity I've never finalized ami-iit/bipedal-locomotion-framework#296.

@S-Dafarra
Copy link
Member Author

S-Dafarra commented Mar 6, 2023

After removing the packaging section, the CI/CD file is broken because of this line

needs: package

@S-Dafarra
Copy link
Member Author

The problem is that without the packaging, I am not sure how to check the inclusion. @traversaro @diegoferigo any suggestion?

@traversaro
Copy link
Contributor

The problem is that without the packaging, I am not sure how to check the inclusion. @traversaro @diegoferigo any suggestion?

My bad, the job to remove was publish, not package.

@diegoferigo
Copy link
Member

The problem is that without the packaging, I am not sure how to check the inclusion. @traversaro @diegoferigo any suggestion?

My bad, the job to remove was publish, not package.

I'd actually suggest to keep the job there and just comment out the Upload artifacts step.

@S-Dafarra
Copy link
Member Author

The problem is that without the packaging, I am not sure how to check the inclusion. @traversaro @diegoferigo any suggestion?

My bad, the job to remove was publish, not package.

I'd actually suggest to keep the job there and just comment out the Upload artifacts step.

I think it is necessary for

- name: Download Python packages
uses: actions/download-artifact@v3
with:
path: dist
name: dist
- name: Install wheel
shell: bash
run: pip install dist/*.whl
- name: Import the package
run: python -c "import hippopt"

@diegoferigo
Copy link
Member

Sorry @S-Dafarra the file in this PR keeps changing and it's difficult to point to a section. I had a better look to the workflow. I agree with @traversaro, we can remove/comment out the entire publish job. I forgot the workflow has a test job that already pulls the artifact and tests the wheel.

For what regards deployment to PyPI, we should discuss it separately since there might be limitations in the current dependencies that are on PyPI (particularly the casadi wheel, and blf if we want to use it).

Copy link
Member

@diegoferigo diegoferigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, just the last leftover.

Lastly, you can consider specifying the citation in a CITATION.cff file.

setup.cfg Outdated Show resolved Hide resolved
@S-Dafarra
Copy link
Member Author

Lastly, you can consider specifying the citation in a CITATION.cff file.

Good point. I am trying to check if I can generate it in some way

@S-Dafarra
Copy link
Member Author

Lastly, you can consider specifying the citation in a CITATION.cff file.

Good point. I am trying to check if I can generate it in some way

I did not find anything, but I also noticed that bib files should be supported too: https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-citation-files#other-citation-files

@S-Dafarra
Copy link
Member Author

All green. Squashing and merging

@S-Dafarra S-Dafarra merged commit e34ff71 into main Mar 6, 2023
@S-Dafarra S-Dafarra deleted the skeleton branch March 7, 2023 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants